Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Add endpoint for sdk deprecations #88794

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Apr 4, 2025

This adds an new endpoint to return the list of sdks used that are deprecated for a event type. Only 1 SDK needs to be up to date for a project. This is because if we require all SDKs for a project to be up to date, then we run into the issue that we may be checking against SDKs that are not currently in use. Addressing this requires a potentially expensive operation of tracking the last time an SDK was seen. Currently only profiles are supported.

This adds an new endpoint to return the list of sdks used that are deprecated
for a event type. Only 1 SDK needs to be up to date for a project. This is
because if we require all SDKs for a project to be up to date, then we run into
the issue that we may be checking against SDKs that are not currently in use.
Addressing this requires a potentially expensive operation of tracking the last
time an SDK was seen. Currently only profiles are supported.
@Zylphrex Zylphrex requested a review from a team as a code owner April 4, 2025 14:20
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...try/api/endpoints/organization_sdk_deprecations.py 95.06% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #88794       +/-   ##
===========================================
+ Coverage   42.13%   87.72%   +45.59%     
===========================================
  Files       10033    10066       +33     
  Lines      567602   569323     +1721     
  Branches    22355    22348        -7     
===========================================
+ Hits       239147   499450   +260303     
+ Misses     328056    69493   -258563     
+ Partials      399      380       -19     

@Zylphrex Zylphrex merged commit cf2da45 into master Apr 4, 2025
49 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/add-endpoint-for-sdk-deprecations branch April 4, 2025 16:01
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
This adds an new endpoint to return the list of sdks used that are
deprecated for a event type. Only 1 SDK needs to be up to date for a
project. This is because if we require all SDKs for a project to be up
to date, then we run into the issue that we may be checking against SDKs
that are not currently in use. Addressing this requires a potentially
expensive operation of tracking the last time an SDK was seen. Currently
only profiles are supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants