feat(grouping): Do not categorize these packages as in-app #88787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking these frames as system will prevent deriving in-app stack trace rules for them. Using `-app` is not enough to skip the derivation system. *NOTE*: Some of the modules are still just marked with `-app` and they will be handled in a following PR in order to keep the diff to a minimum
e90544b to
36b1794
Compare
armenzg
commented
Apr 4, 2025
| @@ -119,25 +119,53 @@ family:native package:libobjc* category=system | |||
| family:native package:libsystem* category=system | |||
| family:native package:/system/** category=system | |||
| family:native package:/vendor/** category=system | |||
| module:dalvik.system.* category=system | |||
| module:com.android.* category=system | |||
There was a problem hiding this comment.
Moved these to the block below.
| family:native package:libdispatch.dylib category=system | ||
| family:native package:WebKit category=system | ||
| family:native package:**/libart.so category=system | ||
| package:/apex/com.android.*/lib*/** category=system | ||
|
|
||
|
|
||
| ## java |
There was a problem hiding this comment.
The new packages included come from conversations with @lcian
|
|
||
| ## java | ||
| # Having a category prevents deriving in_app stack trace rules | ||
| # XXX: Adjust all -app lines in the next PR |
There was a problem hiding this comment.
Some of these lines have -app instead of a category. I will handle them in the following PR. I prioritized keeping the diff to a minimum, and in some cases, I saw hash changes that I wanted to investigate.
| module:feign.* category=system | ||
| module:dalvik.system.* category=system | ||
| module:io.opentelemetry.* category=system | ||
| module:io.sentry.* -app -group |
There was a problem hiding this comment.
Some of the lines here come from the bottom of this file:
...uping/snapshots/test_variants/test_event_hash_variant/newstyle@2023_01_11/android_anr.pysnap
Show resolved
Hide resolved
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Categorizing these frames will prevent deriving in-app stack trace rules for them. A flaw with my system is that many Java packages can be forked, thus, the derivation system will categorize them as in-app.
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
Categorizing these frames will prevent deriving in-app stack trace rules for them. A flaw with my system is that many Java packages can be forked, thus, the derivation system will categorize them as in-app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Categorizing these frames will prevent deriving in-app stack trace rules for them.
A flaw with my system is that many Java packages can be forked, thus, the derivation system will categorize them as in-app.