Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(js): Remove browserHistory from gsBanner #88765

Merged
merged 1 commit into from
Apr 4, 2025
Merged

ref(js): Remove browserHistory from gsBanner #88765

merged 1 commit into from
Apr 4, 2025

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner April 3, 2025 23:36
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team April 3, 2025 23:36
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 3, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10120 1 10119 5
View the top 1 failed test(s) by shortest run time 
GSBanner shows past due modal and banner for non-billing users
Stack Traces | 0.06s run time 
TestingLibraryElementError: Unable to find an element by: [data-test-id="modal-continue-button"]

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../gsApp/components/gsBanner.spec.tsx:1844:40)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@evanpurkhiser evanpurkhiser changed the title ref(js): Remove useNavigate from gsBanner ref(js): Remove browserHistory from gsBanner Apr 4, 2025
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-js-remove-usenavigate-from-gsbanner branch from e391bc6 to 9d1fa57 Compare April 4, 2025 01:12
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) April 4, 2025 01:12
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-js-remove-usenavigate-from-gsbanner branch from 9d1fa57 to 1dfee8b Compare April 4, 2025 20:17
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-js-remove-usenavigate-from-gsbanner branch from 1dfee8b to d8ba2af Compare April 4, 2025 20:41
@evanpurkhiser evanpurkhiser merged commit 856f41d into master Apr 4, 2025
41 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-js-remove-usenavigate-from-gsbanner branch April 4, 2025 20:57
@evanpurkhiser evanpurkhiser added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Apr 4, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: f8a8113

getsentry-bot added a commit that referenced this pull request Apr 4, 2025
@getsentry-bot @evanpurkhiser
Revert "ref(js): Remove browserHistory from gsBanner (#88765)"
f8a8113 
This reverts commit 856f41d.

Co-authored-by: evanpurkhiser <[email protected]>
@evanpurkhiser
Copy link
Member Author

Reverting as there seems to be some kind of acceptance test issue

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@evanpurkhiser @andrewshie-sentry
ref(js): Remove browserHistory from gsBanner (#88765)
f0b9700
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@getsentry-bot @evanpurkhiser @andrewshie-sentry
Revert "ref(js): Remove browserHistory from gsBanner (#88765)"
707317e 
This reverts commit 856f41d.

Co-authored-by: evanpurkhiser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellewzhang michellewzhang michellewzhang approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanpurkhiser @getsentry-bot @michellewzhang