test(ui): Remove useOrganization mocks, add lint rule #88763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The organization object can be easily mocked in most tests by passing an organization to the test render function as part of the config in the 2nd argument
```ts
const organization = OrganizationFixture()
render(<Component />, {organization});
```
scttcper
commented
Apr 3, 2025
Comment on lines
-17
to
-18
| const mockUseOrganization = jest.requireMock('sentry/utils/useOrganization').default; | ||
| const mockUseUser = jest.requireMock('sentry/utils/useUser').useUser; |
There was a problem hiding this comment.
fixed types on some of these other mocks
JonasBa
approved these changes
Apr 4, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The organization object can be mocked in tests by passing an organization to the test render function