feat(issue-views): Add save button to issue stream #88757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malwilley
commented
Apr 3, 2025
| grid-template-areas: 'page-filters search sort'; | ||
| } | ||
| ${p => | ||
| p.hasIssueViewSharing |
There was a problem hiding this comment.
Had to modify the grid styles to fit the save button in. Here's what it looks like when the screen is a bit smaller:
MichaelSun48
approved these changes
Apr 4, 2025
| items={[ | ||
| { | ||
| key: 'save-as', | ||
| label: t('Save As'), |
There was a problem hiding this comment.
nit: maybe "Save as New View"? would also increase the width of the button, which would be nice since it's all the way to the window.
There was a problem hiding this comment.
Good call, does look awkwardly tiny right now!
| }, | ||
| ]} | ||
| trigger={props => ( | ||
| <DropdownTrigger |
There was a problem hiding this comment.
nit: this right/left padding looks a little too much to my eye, this is what It looks like w/ 8px padding (down from 16px)
There was a problem hiding this comment.
Yeah agreed, looks like all the buttons we have like this are smaller so the default paddings look alright
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Adds a save button and modal for creating a new view. Saving a new view works by selecting "Save as", but for now the "Save" button behavior has not been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a save button and modal for creating a new view. Saving a new view works by selecting "Save as", but for now the "Save" button behavior has not been implemented.