ref(flags): Simplify onboarding and drawer platform lists #88756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's good to have them separate in case we support a new platform, but haven't made gettingStartedDocs for it yet. |
michellewzhang
approved these changes
Apr 3, 2025
@cmanallen @bruno-garcia any reason these were excluded before? We include all python in the docs site |
|
@aliu39 Probably fine to include them. |
cmanallen
approved these changes
Apr 7, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Simplifies these lists by filtering `static/app/data/platforms` by javascript and python prefixes. Note our PlatformKeys use the `node-` prefix for backend JS, which we don't support yet. Removes 'other' from drawer platforms. We don't have a CTA for other, so there's no point always showing the empty state. With these changes we're also including these python platforms we didn't have before: `asgi awslambda celery chalice gcpfunctions pylons pymongo rq serverless tryton wsgi`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies these lists by filtering
static/app/data/platformsby javascript and python prefixes. Note our PlatformKeys use thenode-prefix for backend JS, which we don't support yet.Removes 'other' from drawer platforms. We don't have a CTA for other, so there's no point always showing the empty state.
With these changes we're also including these python platforms we didn't have before:
asgi awslambda celery chalice gcpfunctions pylons pymongo rq serverless tryton wsgi