ref(shared-views): Change visibility query param to createdBy #88754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshFerge
approved these changes
Apr 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
All views are shared now, so we're making the table groups "My Views" and "Others" (names are _very_ subject to change) Previously, the groups were based on visibility, hence why we needed a "visibility" query param to filter based on ownership. Now, since we're filtering based on whether the user has created it, we need a new query param — "createdBy" (open to naming suggestions). Next steps are: * Expose whether views are starred or not in the response schema * Add sorting options, including hoisting starred views to the top of the list. This query param is not being used by any public pages, so we do not need to worry about breaking user workflows by just removing the visibility param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All views are shared now, so we're making the table groups "My Views" and "Others" (names are very subject to change)
Previously, the groups were based on visibility, hence why we needed a "visibility" query param to filter based on ownership. Now, since we're filtering based on whether the user has created it, we need a new query param — "createdBy" (open to naming suggestions).
Next steps are:
This query param is not being used by any public pages, so we do not need to worry about breaking user workflows by just removing the visibility param.