chore(ACI): Cleanup tests, use fixtures #88752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b083e15 to
95b869f
Compare
iamrajjoshi
approved these changes
Apr 3, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88752 +/- ##
==========================================
- Coverage 87.73% 87.72% -0.01%
==========================================
Files 10066 10067 +1
Lines 569464 569530 +66
Branches 22355 22355
==========================================
+ Hits 499591 499647 +56
- Misses 69474 69484 +10
Partials 399 399 |
862427c to
3b01fdf
Compare
saponifi3d
approved these changes
Apr 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Create and use fixtures more for consistency so we're not using fixtures in some places and manually creating objects in others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and use fixtures more for consistency so we're not using fixtures in some places and manually creating objects in others