Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(perf): Transaction Summary widget categorized options #88750

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

0Calories
Copy link
Member

@0Calories 0Calories commented Apr 3, 2025

Does some refactoring and allows span category to be included in the queries for the widget charts on the new EAP transaction summary.

  • Widget titles are now dynamic depending on which span category is selected
  • Refactors into individual hooks for each widget visualization to make the logic more readable
  • Properly queries for the right data in the widgets when a category is selected and when not (logic is slightly different)

@0Calories 0Calories self-assigned this Apr 3, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 3, 2025
@0Calories 0Calories marked this pull request as ready for review April 4, 2025 18:41
@0Calories 0Calories requested a review from a team as a code owner April 4, 2025 18:41
@0Calories 0Calories requested review from mjq and Copilot April 4, 2025 18:41
Copilot

This comment was marked as resolved.

Copy link
Member

@mjq mjq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@0Calories 0Calories merged commit e3b2545 into master Apr 7, 2025
42 checks passed
@0Calories 0Calories deleted the ref/ash/txn-summary-categorized-options branch April 7, 2025 17:23
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Does some refactoring and allows span category to be included in the
queries for the widget charts on the new EAP transaction summary.

- Widget titles are now dynamic depending on which span category is
selected
- Refactors into individual hooks for each widget visualization to make
the logic more readable
- Properly queries for the right data in the widgets when a category is
selected and when not (logic is slightly different)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants