🐛 fix: update how we fetch workflow_id and legacy_rule_id from ru… #88748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ def _get_workflow_urls(self, group, rules): | |||
| workflow_urls = [] | |||
| for rule in rules: | |||
| # fetch the workflow_id from the rule.data | |||
| workflow_id = rule.data.get("workflow_id") | |||
| workflow_id = rule.data.get("actions", [{}])[0].get("workflow_id") | |||
There was a problem hiding this comment.
Extracting this logic into a helper function that pulls the workflow ID might make it a bit cleaner to modify in the future.
GabeVillalobos
approved these changes
Apr 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…88748) i realized i made a mistake for how i fetch the `workflow_id` and `legacy_rule_id`. the format that the noa passes down is: https://github.com/getsentry/sentry/blob/fb887ee11cea9e130db2fea435c3f67a21313dab/src/sentry/notifications/notification_action/types.py#L130-L132 essentially ``` { "action" : [ { ... } ] } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i realized i made a mistake for how i fetch the
workflow_idandlegacy_rule_id.the format that the noa passes down is:
sentry/src/sentry/notifications/notification_action/types.py
Lines 130 to 132 in fb887ee
essentially