Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue summary): Cleanup Slack alert design #88747

Merged
merged 2 commits into from
Apr 3, 2025
Merged

fix(issue summary): Cleanup Slack alert design #88747

merged 2 commits into from
Apr 3, 2025

Conversation

roaga
Copy link
Member

@roaga roaga commented Apr 3, 2025

  • removes the eye emoji
  • adds the "Seer" label in footers where it was missing
  • handles error messages that are multiline and were messing up formatting

@roaga roaga requested review from a team as code owners April 3, 2025 21:26
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2025
iamrajjoshi
iamrajjoshi reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@iamrajjoshi iamrajjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picture 👉 👈

@roaga
Copy link
Member Author

roaga commented Apr 3, 2025

@iamrajjoshi
Screenshot 2025-04-03 at 2 17 38 PM

@roaga roaga requested a review from iamrajjoshi April 3, 2025 22:04
@roaga roaga merged commit beabfe8 into master Apr 3, 2025
47 checks passed
@roaga roaga deleted the issue-summary/alert-updates branch April 3, 2025 22:10
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...entry/integrations/slack/message_builder/issues.py 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #88747       +/-   ##
===========================================
+ Coverage   42.15%   87.73%   +45.58%     
===========================================
  Files       10020    10057       +37     
  Lines      566648   569023     +2375     
  Branches    22305    22305               
===========================================
+ Hits       238869   499242   +260373     
+ Misses     327400    69402   -257998     
  Partials      379      379

@iamrajjoshi
Copy link
Member

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...entry/integrations/slack/message_builder/issues.py 77.77% 2 Missing ⚠️
Additional details and impacted files

when u rollout to a broader audience and the notification ui is more stable, prob want a test to cover the missing lines

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@roaga @andrewshie-sentry
fix(issue summary): Cleanup Slack alert design (#88747)
9acfb25 
- removes the eye emoji
- adds the "Seer" label in footers where it was missing
- handles error messages that are multiline and were messing up
formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrajjoshi iamrajjoshi iamrajjoshi approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roaga @iamrajjoshi