chore(uptime): Move UptimeDomainCheckFailure to uptime/grouptype.py
#88746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to keep grouptypes in the module that is related to them, so just moving this out.
roggenkemper
approved these changes
Apr 3, 2025
|
Moving this broke some pickling stuff. I'll just need to import the reference back to where it was for the duration of the deploy |
|
PR reverted: 5dcf746 |
getsentry-bot
added a commit
that referenced
this pull request
Apr 3, 2025
…type.py` (#88746)" This reverts commit ed73d67. Co-authored-by: wedamija <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…#88746) We want to keep grouptypes in the module that is related to them, so just moving this out. <!-- Describe your PR here. -->
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…type.py` (#88746)" This reverts commit ed73d67. Co-authored-by: wedamija <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to keep grouptypes in the module that is related to them, so just moving this out.