ref: add fixture to prevent leaked signal handlers #88740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88740 +/- ##
=======================================
Coverage 87.71% 87.72%
=======================================
Files 10076 10076
Lines 569898 569913 +15
Branches 22387 22387
=======================================
+ Hits 499913 499935 +22
+ Misses 69586 69579 -7
Partials 399 399 |
991fbf8 to
e7de77d
Compare
e7de77d to
9b4a627
Compare
bukzor
approved these changes
Apr 8, 2025
Comment on lines
+157
to
+159
| got is not None | ||
| and not isinstance(got, int) | ||
| and got is not signal.default_int_handler |
There was a problem hiding this comment.
How come this special casing?
Surely if these differ before vs after there's something unhygeinic going on, and the difference between SIG_IGN SIG_DFL and None seems significant, to me.
At least comment and explain?
| @pytest.fixture(autouse=True) | ||
| def check_leaked_signals() -> Generator[None]: | ||
| before = frozenset(_leaked_signals()) | ||
| yield |
There was a problem hiding this comment.
Neat, learned about pytest yield fixtures today :)
Christinarlong
pushed a commit
that referenced
this pull request
Apr 10, 2025
<!-- Describe your PR here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.