Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issues): Add /suspect/tags/ endpoint #88737

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Apr 3, 2025

This is not expected to be the final version of the endpoint. This is a starting point for the issues team to work off of. For now it uses the feature flag logic which may or may not be applicable to tags.

The endpoint and the suspect_tags module are copies of the suspect-flags endpoint and module (with context appropriate changes). The two units of work should expect to diverge over time. There is no need to abstract these modules for re-use. It will only introduce dependencies between our teams.

@cmanallen cmanallen requested review from a team as code owners April 3, 2025 20:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2025
Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you mentioned we'll use a different scoring algorithm soon right

Co-authored-by: Andrew Liu <[email protected]>
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 97.74436% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/issues/suspect_tags.py 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88737      +/-   ##
==========================================
+ Coverage   87.73%   87.74%   +0.01%     
==========================================
  Files       10057    10066       +9     
  Lines      568878   569509     +631     
  Branches    22322    22322              
==========================================
+ Hits       499098   499718     +620     
- Misses      69401    69412      +11     
  Partials      379      379              

@cmanallen cmanallen merged commit 29dabc7 into master Apr 7, 2025
49 checks passed
@cmanallen cmanallen deleted the cmanallen/issues-suspect-tags branch April 7, 2025 14:18
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
This is not expected to be the final version of the endpoint. This is a
starting point for the issues team to work off of. For now it uses the
feature flag logic which may or may not be applicable to tags.

The endpoint and the suspect_tags module are copies of the suspect-flags
endpoint and module (with context appropriate changes). The two units of
work should expect to diverge over time. There is no need to abstract
these modules for re-use. It will only introduce dependencies between
our teams.

---------

Co-authored-by: Andrew Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants