feat(ui): Create and use element id for ECharts when using tooltip.appendToBody
#88735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppendToBody` ECharts has a tooltip option (`appendToBody`) to append the tooltip to `document.body`. This is useful when the charts has a parent container that has e.g. `overflow: hidden` so that the tooltip does not get cutoff. However we have a [custom tooltip positioning function](https://github.com/getsentry/sentry/blob/master/static/app/components/charts/components/tooltip.tsx#L403) that requires a element id to get a reference of the chart (or its container) to properly position the tooltip. If we use `appendToBody` without an `id`, the tooltip does not get displayed near the mouse cursor.
|
This also goes ahead and uses |
scttcper
approved these changes
Apr 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…ppendToBody` (#88735) ECharts has a tooltip option (`appendToBody`) to append the tooltip to `document.body`. This is useful when the charts has a parent container that has e.g. `overflow: hidden` so that the tooltip does not get cutoff. However we have a [custom tooltip positioning function](https://github.com/getsentry/sentry/blob/master/static/app/components/charts/components/tooltip.tsx#L403) that requires a element id to get a reference of the chart (or its container) to properly position the tooltip. If we use `appendToBody` without an `id`, the tooltip does not get displayed near the mouse cursor and instead it's confined within the bounds of the chart. ### Before The crosshairs is where the mouse is (above series both both screenshots)  Here the tooltip is not near the series or the mouse  ### After Notice the tooltips are near the crosshairs  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECharts has a tooltip option (
appendToBody) to append the tooltip todocument.body. This is useful when the charts has a parent container that has e.g.overflow: hiddenso that the tooltip does not get cutoff. However we have a custom tooltip positioning function that requires a element id to get a reference of the chart (or its container) to properly position the tooltip. If we useappendToBodywithout anid, the tooltip does not get displayed near the mouse cursor and instead it's confined within the bounds of the chart.Before
The crosshairs is where the mouse is (above series both both screenshots)
Here the tooltip is not near the series or the mouse
After
Notice the tooltips are near the crosshairs
