fix(visibility): Return meta in span samples responses

[gggritso]

Right now, /spans-samples doesn't return any meta, only "data". This PR runs the response through handle_results_with_meta and returns it, which includes the correct standard meta.

Closes DAIN-49: Return meta from span samples endpoint

[wmak]

small comment, lgtm otherwise

[wmak]

Are we not able to just force this on always instead of needing the param

[gggritso]

You tell me, honestly! I followed what the other endpoints do. For EAP, it's always on, for indexed spans, there's a parameter. I think that'll make it easier to coordinate switching over, but it's probably a small difference

[wmak]

I'd prefer if we can move away from needing this parameter at all, if the frontend doesn't need it un-transformed lets just not use this? ie. does the frontend need the old format still?

[gggritso]

🤔 well, the meta isn't in use at all right now, so I guess I could just force it, yeah! I'll probably replacing all the frontend usages of this at the same time anyway. I'll get rid of it 👍🏻

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ InvalidSearchQuery: Invalid value 200 for transaction.status condition. Accepted values are aborted, already_exists, cancelled, data_loss, deadline_exceeded, failed_precondition, internal_error, invalid_argument, not_found, ok, out_of_range, permission_denied, resource_exh... /api/0/organizations/{organization_id_or_slug}/... View Issue

_{Did you find this useful? React with a 👍 or 👎}