chore(issues): Default to the new issue details in tests #88725

leeandher · 2025-04-03T19:29:10Z

Only one of these is probably necessary to convert all of the useHasStreamlineUI invocations to return true, but this also works.

codecov · 2025-04-03T19:33:20Z

❌ 36 Tests Failed:

Tests completed	Failed	Passed	Skipped
10131	36	10095	5

View the top 3 failed test(s) by shortest run time

groupEvents shows discover query error message

Stack Traces | 0.031s run time

TestingLibraryElementError: Unable to find an element by: [data-test-id="loading-error"]

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../views/issueDetails/groupEvents.spec.tsx:382:40)

groupEvents displays event filters and tags

Stack Traces | 1.01s run time

Error: Unable to find an element with the placeholder text of: Search events…

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../views/issueDetails/groupEvents.spec.tsx:158:53)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

GroupActivity regression renders regression with version

Stack Traces | 1.02s run time

Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.



Error: No mocked response found for request: GET .../issues/1337/tags/
    at createWrapper (.../views/issueDetails/groupActivity.spec.tsx:76:44)
    at Object.<anonymous> (.../views/issueDetails/groupActivity.spec.tsx:598:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:46:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)



Error: No mocked response found for request: GET .../1337/events/recommended/
    at createWrapper (.../views/issueDetails/groupActivity.spec.tsx:76:44)
    at Object.<anonymous> (.../views/issueDetails/groupActivity.spec.tsx:598:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:46:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)



Error: No mocked response found for request: GET ....../organizations/org-slug/sentry-app-installations/
    at createWrapper (.../views/issueDetails/groupActivity.spec.tsx:76:44)
    at Object.<anonymous> (.../views/issueDetails/groupActivity.spec.tsx:598:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:46:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)



Error: No mocked response found for request: GET ....../organizations/org-slug/sentry-app-components/
    at createWrapper (.../views/issueDetails/groupActivity.spec.tsx:76:44)
    at Object.<anonymous> (.../views/issueDetails/groupActivity.spec.tsx:598:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at Object.<anonymous> (.../app/__mocks__/api.tsx:46:15)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

leeandher · 2025-04-07T20:18:44Z

The actual change is in 93b100d, the rest are fixes to address test failures. For test files that are not rendered in the new UI (e.g. groupActivity.spec.tsx) I made them explicitly mock the legacy UI.

When we're deleting these tests, it might be double checking that they all have equivalents in the new test files.

leeandher · 2025-04-07T20:22:26Z

static/app/views/issueDetails/groupSidebar.tsx

No need for checks in this file, it is not used in the new UI.

Only one of these is probably necessary to convert all of the `useHasStreamlineUI` invocations to return `true`, but this also works.

leeandher changed the title ~~chore(issues): Default to the new UI in tests~~ chore(issues): Default to the new issue details in tests Apr 3, 2025

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 3, 2025

vercel bot deployed to Preview April 3, 2025 19:34 View deployment

leeandher force-pushed the leander/update-default branch from dd9c5d0 to b2fe636 Compare April 4, 2025 19:55

vercel bot deployed to Preview April 4, 2025 20:00 View deployment

leeandher force-pushed the leander/update-default branch 3 times, most recently from a21dfa1 to e903291 Compare April 4, 2025 20:39

vercel bot deployed to Preview April 4, 2025 20:44 View deployment

vercel bot deployed to Preview April 4, 2025 21:05 View deployment

leeandher force-pushed the leander/update-default branch from ec354a7 to adcbb68 Compare April 7, 2025 19:09

leeandher added 7 commits April 7, 2025 15:14

✅ Let's see what fails

93b100d

✅ Fix tests in Jest(0)

7f7b722

✅ Fix tests in Jest(3)

ee790d7

✅ Test fixes on Jest (0)

0bd311a

✅ Test fixes on Jest (2)

410882d

✅ Test fixes on Jest (3)

303265a

✅ Test fixes on Jest (1) pt.1

d096981

leeandher force-pushed the leander/update-default branch from adcbb68 to d096981 Compare April 7, 2025 19:14

vercel bot deployed to Preview April 7, 2025 19:21 View deployment

✅ Test fixes on Jest (1) pt.2

9c3bdc3

vercel bot deployed to Preview April 7, 2025 20:01 View deployment

leeandher marked this pull request as ready for review April 7, 2025 20:18

leeandher requested review from a team as code owners April 7, 2025 20:18

🔥 rm comment

631148b

leeandher commented Apr 7, 2025

View reviewed changes

static/app/views/issueDetails/groupSidebar.tsx

Copy link

Member Author

leeandher Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for checks in this file, it is not used in the new UI.

vercel bot deployed to Preview April 7, 2025 20:24 View deployment

✅ Mock header with streamline only

bca0bd8

vercel bot deployed to Preview April 7, 2025 20:32 View deployment

scttcper approved these changes Apr 7, 2025

View reviewed changes

leeandher merged commit bf8b31d into master Apr 8, 2025
41 checks passed

leeandher deleted the leander/update-default branch April 8, 2025 13:56

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025

chore(issues): Default to the new issue details in tests (#88725)

880ff3c

Only one of these is probably necessary to convert all of the `useHasStreamlineUI` invocations to return `true`, but this also works.

Christinarlong pushed a commit that referenced this pull request Apr 10, 2025

chore(issues): Default to the new issue details in tests (#88725)

4ed4acd

Only one of these is probably necessary to convert all of the `useHasStreamlineUI` invocations to return `true`, but this also works.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(issues): Default to the new issue details in tests #88725

chore(issues): Default to the new issue details in tests #88725

leeandher commented Apr 3, 2025

codecov bot commented Apr 3, 2025 •

edited

Loading

leeandher commented Apr 7, 2025

leeandher Apr 7, 2025

chore(issues): Default to the new issue details in tests #88725

chore(issues): Default to the new issue details in tests #88725

Conversation

leeandher commented Apr 3, 2025

codecov bot commented Apr 3, 2025 • edited Loading

❌ 36 Tests Failed:

leeandher commented Apr 7, 2025

leeandher Apr 7, 2025

Choose a reason for hiding this comment

codecov bot commented Apr 3, 2025 •

edited

Loading