ref(insights): use http_response_count(5) instead of http_error_count in frontend
#88724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88724 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 10055 10055
Lines 568709 568701 -8
Branches 22324 22323 -1
=======================================
Hits 498977 498977
+ Misses 69353 69345 -8
Partials 379 379 |
gggritso
approved these changes
Apr 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…unt` in frontend (#88724) 1. `http_error_count` is deprecated in span metrics and not available in eap. This PR switches `http_error_count` to `http_response_count(5)` 2. removes usage of old use discover hook in favour of `useSpansMetrics` which supports the eap toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_error_countis deprecated in span metrics and not available in eap. This PR switcheshttp_error_counttohttp_response_count(5)removes usage of old use discover hook in favour of
useSpansMetricswhich supports the eap toggle.