Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fe): Convert <IntegrationOrganizationLink /> to an FC #88720

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

leeandher
Copy link
Member

Converts this class to a functional component. it's structured quite a bit differently in order to use ApiQuery instead of the direct usage of api. It seemed to work with tests, and I believe the logic is the same, but the onSelectOrg function from the previous version had quite a few side effects that I've pulled out. Instead, the ApiQuery hooks should fire when the selectedOrgSlug changes.

ref: https://github.com/getsentry/frontend-tsc/issues/2

@leeandher leeandher changed the title chore(fe): Convert <IntegrationOrganizationLink /> to an FC #88680 chore(fe): Convert <IntegrationOrganizationLink /> to an FC Apr 3, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 3, 2025
@leeandher leeandher changed the title chore(fe): Convert <IntegrationOrganizationLink /> to an FC chore(fe): Convert <IntegrationOrganizationLink /> to an FC Apr 3, 2025
@leeandher leeandher marked this pull request as ready for review April 3, 2025 19:19
@leeandher leeandher requested a review from a team April 3, 2025 20:48
@leeandher leeandher merged commit 43a1711 into master Apr 7, 2025
42 checks passed
@leeandher leeandher deleted the leander/fc-integrationOrganizationLink branch April 7, 2025 16:00
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Converts this class to a functional component. it's structured quite a
bit differently in order to use `ApiQuery` instead of the direct usage
of `api`. It seemed to work with tests, and I believe the logic is the
same, but the `onSelectOrg` function from the previous version had quite
a few side effects that I've pulled out. Instead, the ApiQuery hooks
should fire when the `selectedOrgSlug` changes.

ref: getsentry/frontend-tsc#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants