fix(aci): Add exclusion constraint for GroupOpenPeriod #88710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has a migration; here is the generated SQL for --
-- Raw SQL operation
--
ALTER TABLE "sentry_groupopenperiod"
ADD CONSTRAINT "exclude_overlapping_start_end" EXCLUDE USING GIST (
"group_id" gist_int8_ops WITH =,
(TSTZRANGE("date_started", "date_ended", '[)')) WITH &&
); |
|
ugh i didn't mean to update the branch, CI was almost done and green 😭 |
wedamija
approved these changes
Apr 3, 2025
| # is a schema change, it's completely safe to run the operation after the code has deployed. | ||
| # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment | ||
|
|
||
| is_post_deployment = False |
There was a problem hiding this comment.
I'd probably just mark this as post deploy to avoid any problems
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
The previous attempt (#88484) to do this failed because of the order of operations, so we've split this up into two steps: 1. remove the existing constraint #88708 2. add a new updated constraint (this pr) Note that the table is empty. For context, the old exclusion constraint looks only for overlapping ranges of (date_started, date_ended). We need to enforce this constraint for each group, so that no distinct group has two open periods that overlap. The table itself is expected to have multiple overlapping ranges since we'll have one row per group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt (#88484) to do this failed because of the order of operations, so we've split this up into two steps:
Note that the table is empty. For context, the old exclusion constraint looks only for overlapping ranges of (date_started, date_ended). We need to enforce this constraint for each group, so that no distinct group has two open periods that overlap. The table itself is expected to have multiple overlapping ranges since we'll have one row per group.