Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(crons): Remove monitors Location model (state) #88704

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested review from a team as code owners April 3, 2025 17:08
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team April 3, 2025 17:08
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2025
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) April 3, 2025 17:10
@vgrozdanic
Copy link
Member

I see this model also being present in secondary_db_models in src/sentry/db/router.py in TestSiloMultiDatabaseRouter class, we should also remove it from there

@evanpurkhiser
Copy link
Member Author

Good catch! Thanks @vgrozdanic

Copy link
Contributor

github-actions bot commented Apr 3, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0860_monitors_remove_location.py ()

--
-- Moved model MonitorLocation to pending deletion state
--
-- (no-op)

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #88704   +/-   ##
=======================================
  Coverage   87.72%   87.72%           
=======================================
  Files       10065    10064    -1     
  Lines      569169   569151   -18     
  Branches    22348    22348           
=======================================
- Hits       499294   499284   -10     
+ Misses      69495    69487    -8     
  Partials      380      380           

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitors-location-model-state- branch from 9ef75ff to caf7d8a Compare April 3, 2025 17:20
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitors-location-model-state- branch from ec15c72 to 0a89d0c Compare April 3, 2025 17:29
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitors-location-model-state- branch from 0a89d0c to da42794 Compare April 3, 2025 17:55
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitors-location-model-state- branch from da42794 to 8cef12a Compare April 3, 2025 23:17
Copy link
Contributor

github-actions bot commented Apr 3, 2025

This PR has a migration; here is the generated SQL for src/sentry/migrations/0861_monitors_remove_location.py ()

--
-- Moved model MonitorLocation to pending deletion state
--
-- (no-op)

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-crons-remove-monitors-location-model-state- branch from 8cef12a to c35b09c Compare April 3, 2025 23:31
@evanpurkhiser evanpurkhiser disabled auto-merge April 3, 2025 23:51
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) April 3, 2025 23:51
@evanpurkhiser evanpurkhiser merged commit 760f7c9 into master Apr 4, 2025
47 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-remove-monitors-location-model-state- branch April 4, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants