Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert-comparison): Add some more logging for timeseries comparison #88700

Merged

Conversation

shruthilayaj
Copy link
Member

@shruthilayaj shruthilayaj commented Apr 3, 2025

Add some logging so we can track why alerts are mismatched. This should give me a high level overview of why timeseries are mismatched, let us aggregate some data.

Translation for http.method, title and event.type:transaction filter.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2025
@shruthilayaj shruthilayaj changed the title Shruthi/feat/add more logging for timeseries comparison feat(alert-comparison): Add some more logging for timeseries comparison Apr 3, 2025
@shruthilayaj shruthilayaj marked this pull request as ready for review April 3, 2025 16:55
@shruthilayaj shruthilayaj requested a review from a team as a code owner April 3, 2025 16:56
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 51.51515% with 48 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/discover/compare_timeseries.py 30.43% 48 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #88700       +/-   ##
===========================================
+ Coverage   46.47%   87.74%   +41.26%     
===========================================
  Files       10026    10044       +18     
  Lines      567380   568640     +1260     
  Branches    22287    22287               
===========================================
+ Hits       263690   498940   +235250     
+ Misses     303286    69296   -233990     
  Partials      404      404               

@shruthilayaj shruthilayaj enabled auto-merge (squash) April 3, 2025 19:09
@shruthilayaj shruthilayaj merged commit 7c7b2b4 into master Apr 3, 2025
48 checks passed
@shruthilayaj shruthilayaj deleted the shruthi/feat/add-more-logging-for-timeseries-comparison branch April 3, 2025 19:38
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
…on (#88700)

Add some logging so we can track why alerts are mismatched. This should
give me a high level overview of why timeseries are mismatched, let us
aggregate some data.

Translation for http.method, title and event.type:transaction filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants