feat(dashboards-eap): Add progressive loading for tables #88697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loading-for-tables
DominikB2014
approved these changes
Apr 4, 2025
static/app/views/dashboards/widgetCard/spansWidgetQueries.spec.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+124
to
+127
| referrer, | ||
| undefined, | ||
| undefined, | ||
| samplingMode |
There was a problem hiding this comment.
Unrelated to this PR, but we should probably consider making this a object instead of passing in undefined multiple times
There was a problem hiding this comment.
Totally, it's on my TODO list to change these to objects because ugh lol every time someone has to add one, you need to do this, but I'll leave it off for another PR
There was a problem hiding this comment.
100% it should be handled separately imo
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Supports tables for the progressive loading method in dashboards. The updates required for this require us to pass the sampling mode down to the method in the dataset config for spans which then passes it to the query params in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports tables for the progressive loading method in dashboards. The updates required for this require us to pass the sampling mode down to the method in the dataset config for spans which then passes it to the query params in the request.