ref: bump sentry-arroyo to 2.20.7 #88694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: untitaker <[email protected]>
untitaker
approved these changes
Apr 3, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #88694 +/- ##
===========================================
+ Coverage 32.97% 87.81% +54.83%
===========================================
Files 8493 10059 +1566
Lines 474755 569582 +94827
Branches 22303 22303
===========================================
+ Hits 156572 500181 +343609
+ Misses 317779 68997 -248782
Partials 404 404 |
asottile-sentry
previously requested changes
Apr 4, 2025
| produce_future.add_done_callback( | ||
| # We know this type is futures.Future, but cannot assert so, | ||
| # because it is also mock.Mock in tests. | ||
| produce_future.add_done_callback( # type:ignore[attr-defined] |
There was a problem hiding this comment.
this points out that an annotation or mock is wrong somewhere. we should only use type ignore for bugs in the type checker not bugs in the code
There was a problem hiding this comment.
basically the type annotation in arroyo is wrong, and expressing the right thing is too complicated. this usage of producers is also not very common.
There was a problem hiding this comment.
let's fix the annotation then. or revert
we're going to follow up with a fix to the types.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Co-Authored-By: untitaker <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: untitaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: untitaker [email protected]