alerts: use chonk colors #88688
Merged
alerts: use chonk colors #88688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
commented
Apr 3, 2025
Comment on lines
+145
to
+162
| function getColor(theme: Theme, type: 'critical' | 'warning' | 'success') { | ||
| if (theme.isChonk) { | ||
| return type === 'critical' | ||
| ? (theme as DO_NOT_USE_ChonkTheme).colors.chonk.red400 | ||
| : type === 'warning' | ||
| ? (theme as DO_NOT_USE_ChonkTheme).colors.chonk.yellow400 | ||
| : (theme as DO_NOT_USE_ChonkTheme).colors.chonk.green400; | ||
| } | ||
| return type === 'critical' | ||
| ? theme.errorText | ||
| : type === 'warning' | ||
| ? theme.warningText | ||
| : theme.successText; | ||
| } | ||
| const StyledIconDiamond = styled(IconDiamond)<{type: 'critical' | 'warning' | 'success'}>` | ||
| fill: ${p => getColor(p.theme, p.type)}; | ||
| `; | ||
|
|
There was a problem hiding this comment.
The IconDiamond is deprecated and will be removed in the future so I didnt bother making a dedicated component for it
TkDodo
approved these changes
Apr 3, 2025
| @@ -40,7 +40,9 @@ const numericStyle = ( | |||
| height: 24px; | |||
| font-weight: ${theme.fontWeightNormal}; | |||
| font-size: ${theme.fontSizeSmall}; | |||
| background-color: ${theme.yellow300}; | |||
| background-color: ${theme.isChonk | |||
| ? (theme as DO_NOT_USE_ChonkTheme).colors.chonk.yellow400 | |||
There was a problem hiding this comment.
let’s do the isChonkTheme assert function to avoid the type assertion we need to do in a couple of places.
There was a problem hiding this comment.
Yeah, let me followup with that and fix it in a bunch of other places too
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Cleared with Jesse that elements that need contrast from the base should use chonk colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleared with Jesse that elements that need contrast from the base should use chonk colors