chore(fe): Convert <IntegrationListDirectory /> to an FC
#88680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<IntegrationListDirectory /> to an FC
<IntegrationListDirectory /> to an FC<IntegrationListDirectory /> to an FC
leeandher
commented
Apr 3, 2025
| TEXT_SEARCH_ANALYTICS_DEBOUNCE_IN_MS | ||
| ); | ||
|
|
||
| function useIntegrationList() { |
There was a problem hiding this comment.
Made this hook since this component makes 7-8 API calls in parallel and coerces them into one list. It's not reused anywhere but it made looking at the component hard to navigate.
scttcper
approved these changes
Apr 3, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Converts this component to three different components and one hook. Mostly done to isolate concerns, these aren't reused anywhere but it made it easier to read in my opinion. Also moved some functions to utils since this component did a lot. ref: getsentry/frontend-tsc#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts this component to three different components and one hook. Mostly done to isolate concerns, these aren't reused anywhere but it made it easier to read in my opinion. Also moved some functions to utils since this component did a lot.
ref: https://github.com/getsentry/frontend-tsc/issues/2