-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aci milestone 3): anomaly detection condition handler #88647
base: master
Are you sure you want to change the base?
Conversation
SEER_ANOMALY_DETECTION_CONNECTION_POOL = connection_from_url( | ||
settings.SEER_ANOMALY_DETECTION_URL, | ||
timeout=settings.SEER_ANOMALY_DETECTION_TIMEOUT, | ||
) | ||
|
||
|
||
@condition_handler_registry.register(Condition.ANOMALY_DETECTION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this data condition live in the incidents
directory? 🤔 it's all hooked into the workflow_engine with this registry, which allows us to store it anywhere.
i think that might help keep the workflow_engine a bit more isolated, then if we want to add anomaly detection to other kinds of detectors in the future, we can worry about making it more generic then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we made a new condition handler subdirectory within the incidents directory?
src/sentry/workflow_engine/handlers/condition/anomaly_detection_handler.py
Outdated
Show resolved
Hide resolved
src/sentry/workflow_engine/handlers/condition/anomaly_detection_handler.py
Outdated
Show resolved
Hide resolved
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Open question: