🔧 chore(slack): don't prefetch assignee options #88641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabeVillalobos
approved these changes
Apr 2, 2025
cathteng
approved these changes
Apr 3, 2025
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
this pr will fix a subset of the issues in https://sentry.sentry.io/issues/5392362510/?project=1 `get_options_groups` made an expensive RPC call which is prone to timeouts in reality, when we are building the assignee dropdown, we shouldn't be adding option groups since we actually don't need it. the assignee dropdown is a dynamic field, for which slack sends us webhooks when a user types something. we then respond back with possible options. i tested that the behavior locally and nothing seems to have broken: https://github.com/user-attachments/assets/de6b314d-6b00-4b1e-90cb-aeb16cde2b62
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
this pr will fix a subset of the issues in https://sentry.sentry.io/issues/5392362510/?project=1 `get_options_groups` made an expensive RPC call which is prone to timeouts in reality, when we are building the assignee dropdown, we shouldn't be adding option groups since we actually don't need it. the assignee dropdown is a dynamic field, for which slack sends us webhooks when a user types something. we then respond back with possible options. i tested that the behavior locally and nothing seems to have broken: https://github.com/user-attachments/assets/de6b314d-6b00-4b1e-90cb-aeb16cde2b62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr will fix a subset of the issues in https://sentry.sentry.io/issues/5392362510/?project=1
get_options_groupsmade an expensive RPC call which is prone to timeoutsin reality, when we are building the assignee dropdown, we shouldn't be adding option groups since we actually don't need it.
the assignee dropdown is a dynamic field, for which slack sends us webhooks when a user types something. we then respond back with possible options.
i tested that the behavior locally and nothing seems to have broken:
Screen.Recording.2025-04-02.at.2.45.11.PM.mov