fix(flamegraph): Limit flamegraph height in profile summary tab #88638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple roots, we need to make sure to deduplicate the references otherwise the same reference can show up multiple times.
indragiek
approved these changes
Apr 2, 2025
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
The list of profile references can cause the panel to grow. If there are too many, the canvas will grow to a size where it doesn't render correctly anymore. Limit the size of the list of profile references which will limit the size of the canvas.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
The list of profile references can cause the panel to grow. If there are too many, the canvas will grow to a size where it doesn't render correctly anymore. Limit the size of the list of profile references which will limit the size of the canvas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of profile references can cause the panel to grow. If there are too many, the canvas will grow to a size where it doesn't render correctly anymore. Limit the size of the list of profile references which will limit the size of the canvas.