settings: fix tabs #88624
Merged
settings: fix tabs #88624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
approved these changes
Apr 2, 2025
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
This looks like it mighthave been broken before my tab change, as it was
calling `recreateRoute('')` for both paths? I'm not sure if
recreateRoute is even needed then given this signature, but maybe
someone with more knowledge can correct me here please
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This looks like it mighthave been broken before my tab change, as it was
calling `recreateRoute('')` for both paths? I'm not sure if
recreateRoute is even needed then given this signature, but maybe
someone with more knowledge can correct me here please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like it mighthave been broken before my tab change, as it was calling
recreateRoute('')for both paths? I'm not sure if recreateRoute is even needed then given this signature, but maybe someone with more knowledge can correct me here please