🔧 chore: refactor opsgenie client to decompose send notification #88588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrajjoshi
commented
Apr 2, 2025
| @@ -85,40 +85,32 @@ def _get_issue_alert_payload( | |||
| } | |||
| return payload | |||
|
|
|||
| def send_notification( | |||
| def send_notification(self, data): | |||
There was a problem hiding this comment.
this is a simple method which takes a payload and sends a notification
iamrajjoshi
commented
Apr 2, 2025
| ): | ||
| headers = self._get_auth_headers() | ||
| interaction_type = OnCallInteractionType.CREATE | ||
| if isinstance(data, (Event, GroupEvent)): |
There was a problem hiding this comment.
this if statement isn't needed anymore and the logic inside of it now lives in the callee, see notification.py
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88588 +/- ##
===========================================
+ Coverage 45.52% 87.75% +42.23%
===========================================
Files 10005 10027 +22
Lines 566929 567907 +978
Branches 22296 22296
===========================================
+ Hits 258068 498354 +240286
+ Misses 308441 69133 -239308
Partials 420 420 |
mifu67
approved these changes
Apr 2, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the opsgenie client's
send_notificationwas also building the payload, which makes things coupled and was making updating the link building logic a little bit more difficult, so i am breaking this logic down.