Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): Make add dashboard template button busy when clicked #88585

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

nikkikapadia
Copy link
Member

@nikkikapadia nikkikapadia commented Apr 2, 2025

I added a state to control if the "Add Dashboard" button has been clicked. Once clicked it will appear busy until the dashboard was added. I've also added a loading message to indicate that the request is being sent to add the dashboard.

image

Contributes to #88191

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 2, 2025
@nikkikapadia nikkikapadia marked this pull request as ready for review April 2, 2025 18:58
@nikkikapadia nikkikapadia requested a review from a team as a code owner April 2, 2025 18:58
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 nice!

@nikkikapadia nikkikapadia merged commit 465534f into master Apr 2, 2025
43 checks passed
@nikkikapadia nikkikapadia deleted the nikki/fix/busy-add-dashboard-template branch April 2, 2025 19:28
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
#88585)

I added a state to control if the "Add Dashboard" button has been
clicked. Once clicked it will appear busy until the dashboard was added.
I've also added a loading message to indicate that the request is being
sent to add the dashboard.

<img width="1199" alt="image"
src="https://github.com/user-attachments/assets/ad304df9-0ba7-40de-adb7-6d503295a533"
/>

Contributes to #88191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants