Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 chore(aci): update links for ticketing action descriptions #88580

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

iamrajjoshi
Copy link
Member

this updates the descriptions links for all ticketing actions for the notification action:

if we are invoking the handler from the notification action, we will create the legacy link from the legacy_rule_id

if we have enabled the workflow ui link building logic, we will use the workflow_id

@iamrajjoshi iamrajjoshi requested review from GabeVillalobos and a team April 2, 2025 17:46
@iamrajjoshi iamrajjoshi self-assigned this Apr 2, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../rules/actions/integrations/create_ticket/utils.py 66.66% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #88580   +/-   ##
=======================================
  Coverage   87.74%   87.75%           
=======================================
  Files       10019    10023    +4     
  Lines      567670   567740   +70     
  Branches    22295    22295           
=======================================
+ Hits       498112   498192   +80     
+ Misses      69138    69128   -10     
  Partials      420      420           

@iamrajjoshi
Copy link
Member Author

Codecov Report

Attention: Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../rules/actions/integrations/create_ticket/utils.py 66.66% 6 Missing ⚠️
Additional details and impacted files

other missing lines are tested by individual action handler tests

@iamrajjoshi iamrajjoshi merged commit 3b13a29 into master Apr 2, 2025
48 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/aci/build-new-ticketing-description-links branch April 2, 2025 20:53
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
this updates the descriptions links for all ticketing actions for the
notification action:

if we are invoking the handler from the notification action, we will
create the legacy link from the `legacy_rule_id`

if we have enabled the workflow ui link building logic, we will use the
`workflow_id`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants