feat(new-trace): Implementing new header designs #88577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 27, 2025 00:46
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
scttcper
reviewed
Apr 3, 2025
static/app/components/events/highlights/highlightsIconSummary.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceHeader/breadcrumbs.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceHeader/highlights.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceHeader/highlights.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceHeader/placeholder.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceHeader/index.tsx
Outdated
Show resolved
Hide resolved
| const representativeEvent = getRepresentativeEvent(props.tree, props.logs); | ||
| const project = representativeEvent | ||
| ? projects.find(p => { | ||
| if (OurLogKnownFieldKey.PROJECT_ID in representativeEvent) { |
There was a problem hiding this comment.
nit: I think it makes sense to move this if condition outside of the find loop. Technically, it's running this check on each find iteration, when you actually only need to do it once.
There was a problem hiding this comment.
Agree, i pushed the change
static/app/views/performance/newTraceDetails/traceHeader/meta.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceHeader/projects.tsx
Outdated
Show resolved
Hide resolved
edwardgou-sentry
approved these changes
Apr 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This PR implements the following designs: <img width="945" alt="Screenshot 2025-04-03 at 11 10 21 AM" src="https://github.com/user-attachments/assets/ad761445-c2da-4cd4-b82e-3b4bda43bbe9" /> The `index.tsx` file was getting disorganized, split/added the components to this structure: <img width="461" alt="Screenshot 2025-04-03 at 11 23 26 AM" src="https://github.com/user-attachments/assets/28ccb786-0555-43ae-a55d-e931b279a4fc" /> --------- Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following designs:
The
index.tsxfile was getting disorganized, split/added the components to this structure: