test(ui): Remove useProject mocks, add lint rule #88574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our app bootstrap process initializes ProjectsStore with all available projects, we can do the same in our tests. *Why avoid mocks* - Changing hooks that have been mocked requires updating every test that has mocked that hook. It creates a tight relationship between hooks and random tests. - Mocked tests do not test how components and hooks actually work.
evanpurkhiser
approved these changes
Apr 2, 2025
malwilley
approved these changes
Apr 2, 2025
| { | ||
| selector: | ||
| "CallExpression[callee.object.name='jest'][callee.property.name='mock'][arguments.0.value='sentry/utils/useProjects']", | ||
| message: |
There was a problem hiding this comment.
Appreciate the eslint rule since I assume most of these are just because the person writing the test didn't know they could do this.
There was a problem hiding this comment.
i think a lot lately is cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our app bootstrap process initializes ProjectsStore with all available projects, we can do the same in our tests.
Why avoid mocks