Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nav): Update banner copy #88566

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Apr 2, 2025

Prepping to start releasing this to a small group of EA users.

CleanShot 2025-04-02 at 09 27 58@2x

@malwilley malwilley requested a review from a team April 2, 2025 16:15
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 2, 2025
<Description>
{t("We've redesigned our sidebar to make it easier to navigate Sentry.")}
{t('Say hello to your improved sidebar—less clutter, clearer workflows.')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be spaces around the hyphen? this almost reads like "sidebarless"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what I think you're right, adding spacing looks a bit better

Copy link

codecov bot commented Apr 2, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10083 1 10082 5
View the top 1 failed test(s) by shortest run time
Sidebar New navigation UI prompts should render the sidebar banner with no dismissed prompts and the feature flag enabled
Stack Traces | 1.07s run time
Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

In HTML, <div> cannot be a descendant of <p>.
This will cause a hydration error.

  ...
    <nav aria-label="Primary Na..." className="css-1skly4...">
      <ExpandedContextProvider>
        <SidebarSectionGroupPrimary>
        <SidebarSectionGroup>
          <Insertion>
          <div className="css-104o1o...">
            <LegacyPerformanceOnboardingSidebar>
            <LegacyFeedbackOnboardingSidebar>
            <LegacyReplaysOnboardingSidebar>
            <LegacyFeatureFlagOnboardingSidebar>
            <LegacyProfilingOnboardingSidebar>
            <SidebarSection>
            <SidebarSection centeredItems={false}>
              <Insertion>
              <div className="css-l0bbsf...">
                <OptInBanner collapsed={false} organization={{id:"3",slug:"o...", ...}}>
                  <TranslucentBackgroundPanel isDarkMode={false}>
                    <Insertion>
                    <div className="css-1obyfi...">
                      <PanelProvider>
                        <ThemeProvider theme={{isChonk:false, ...}}>
                          <Title>
                            <Insertion>
>                           <p className="css-1ouzl1t-Title e1t0egys3">
                              <FeatureBadge type="alpha">
                                <Insertion>
                                <InnerFeatureBadge type="alpha" className="css-10knnk...">
>                                 <div className="css-10knnk0-FeatureBadge e1bh8nij0">
                          ...
                ...
            ...

    at console.captureMessage [as error] (.../node_modules/jest-fail-on-console/index.js:83:25)
    at validateDOMNesting (.../react-dom/cjs/react-dom-client.development.js:2494:19)
    at completeWork (.../react-dom/cjs/react-dom-client.development.js:13683:15)
    at runWithFiberInDEV (.../react-dom/cjs/react-dom-client.development.js:543:16)
    at completeUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15179:19)
    at performUnitOfWork (.../react-dom/cjs/react-dom-client.development.js:15061:11)
    at workLoopSync (.../react-dom/cjs/react-dom-client.development.js:14870:41)
    at renderRootSync (.../react-dom/cjs/react-dom-client.development.js:14850:11)
    at performWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:14334:13)
    at performSyncWorkOnRoot (.../react-dom/cjs/react-dom-client.development.js:15946:7)
    at flushSyncWorkAcrossRoots_impl (.../react-dom/cjs/react-dom-client.development.js:15807:21)
    at processRootScheduleInMicrotask (.../react-dom/cjs/react-dom-client.development.js:15841:7)
    at .../react-dom/cjs/react-dom-client.development.js:15962:13
    at invokeTheCallbackFunction (.../living/generated/Function.js:19:26)
    at .../jsdom/browser/Window.js:554:9
    at node:internal/process/task_queues:151:7
    at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)
    at flushUnexpectedConsoleCalls (.../node_modules/jest-fail-on-console/index.js:48:13)
    at Object.<anonymous> (.../node_modules/jest-fail-on-console/index.js:139:7)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusHook (.../jest-circus/build/run.js:281:40)
    at _runTest (.../jest-circus/build/run.js:254:5)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@malwilley malwilley merged commit 4b59594 into master Apr 2, 2025
41 checks passed
@malwilley malwilley deleted the malwilley/feat/nav-banner-copoy branch April 2, 2025 16:42
jan-auer added a commit that referenced this pull request Apr 2, 2025
* master: (96 commits)
  fix(autofix): fix highlight popup behavior (#88552)
  🔧 chore: introduce workflow engine ui links ff (#88569)
  feat(pipeline): Add CoveragePageWrapper component and tests for it (#88519)
  feat(taskworker):Make sdk tasks taskworker compatible (#88488)
  chore(flamegraph): Updating wording to trace (#88516)
  feat(shared-views): Create `GET` `group-search-view/starred` endpoint (#88398)
  DI-612: print flaky pytest errors to log (v2) (#88512)
  chore(nav): Update banner copy (#88566)
  feat(sentryapps): add RPC method to get all installation component contents (#88179)
  chore(issue summary): Add limit to query (#88563)
  fix(dashboards): Add limit suggestion to validation (#88436)
  feat(checkout): show starting PAYG prices (#88510)
  ✨ feat(aci): add workflow_id when creating an ephemeral rule in noa (#88520)
  fix(billing): hide pay now button for self serve partners (#88504)
  chore(HC): Re-adds logging with a low sample rate for cache hits/misses on options (#88464)
  fix(logs): Upgrade sentry log integration to fix dogfooding issues (#88561)
  chore(issue summary): Remove dividers from AI summary alert (#88554)
  feat(insights): Enable bubbles in full-screen mode (#88445)
  fix(explore): Update search bar query on filter change (#88473)
  chore(dependencies): Upgrade drf-spectacular (#88459)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants