Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(logs): xfail test from vcc #88564

Merged
merged 1 commit into from
Apr 3, 2025
Merged

chore(logs): xfail test from vcc #88564

merged 1 commit into from
Apr 3, 2025
+27 −0

Conversation

wmak
Copy link
Member

@wmak wmak commented Apr 2, 2025

  • This xfails a test for project slug in the logs dataset where the VCC isn't being applied

@wmak
chore(logs): xfail test from vcc
9265666 
- This xfails a test for project slug in the logs dataset where the VCC
  isn't being applied
@wmak wmak requested a review from a team as a code owner April 2, 2025 15:45
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../api/endpoints/test_organization_events_ourlogs.py 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #88564       +/-   ##
===========================================
+ Coverage   56.27%   87.74%   +31.47%     
===========================================
  Files       10006    10014        +8     
  Lines      567040   567509      +469     
  Branches    22297    22297               
===========================================
+ Hits       319110   497978   +178868     
+ Misses     247513    69114   -178399     
  Partials      417      417

k-fish added a commit that referenced this pull request Apr 3, 2025
@k-fish
fix(ourlogs): Hide project as a column until backend is fixed
699e314 
This isn't working due to a VCC problem. The test in #88564 has to pass first.
@k-fish k-fish mentioned this pull request Apr 3, 2025
Merged
k-fish added a commit that referenced this pull request Apr 3, 2025
@k-fish
fix(ourlogs): Hide project as a column until backend is fixed (#88684)
626054b 
### Summary
This isn't working due to a VCC problem. The test in #88564 has to pass
first.

#### Screenshots
|![Screenshot 2025-04-03 at 11 21
50 AM](https://github.com/user-attachments/assets/1a20b84d-9ba5-4346-bfb0-b3167e43687a)|
|-|
adrian-codecov pushed a commit that referenced this pull request Apr 3, 2025
@k-fish @adrian-codecov
fix(ourlogs): Hide project as a column until backend is fixed (#88684)
68627d8 
### Summary
This isn't working due to a VCC problem. The test in #88564 has to pass
first.

#### Screenshots
|![Screenshot 2025-04-03 at 11 21
50 AM](https://github.com/user-attachments/assets/1a20b84d-9ba5-4346-bfb0-b3167e43687a)|
|-|
@wmak wmak merged commit a119056 into master Apr 3, 2025
46 checks passed
@wmak wmak deleted the wmak/chore/xfail-test-from-logs-vcc branch April 3, 2025 16:18
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@k-fish @andrewshie-sentry
fix(ourlogs): Hide project as a column until backend is fixed (#88684)
1f8f273 
### Summary
This isn't working due to a VCC problem. The test in #88564 has to pass
first.

#### Screenshots
|![Screenshot 2025-04-03 at 11 21
50 AM](https://github.com/user-attachments/assets/1a20b84d-9ba5-4346-bfb0-b3167e43687a)|
|-|
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@wmak @andrewshie-sentry
chore(logs): xfail test from vcc (#88564)
13e0863 
- This xfails a test for project slug in the logs dataset where the VCC
isn't being applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-fish k-fish k-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmak @k-fish