fix(logs): Upgrade sentry log integration to fix dogfooding issues #88561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
colin-sentry
commented
Apr 2, 2025
- Some things you tried to log would fail because they weren't JSON-able
- There is now batching logic to reduce CPU load
- Various things have been renamed (like before_emit_log -> before_send_log)
untitaker
approved these changes
Apr 2, 2025
k-fish
approved these changes
Apr 2, 2025
|
Ignore me, talked with Colin offline, the logging integration using an option wasn't the root cause, should be fine when they land logging with the |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88561 +/- ##
==========================================
+ Coverage 87.74% 87.81% +0.06%
==========================================
Files 10014 10019 +5
Lines 567451 567753 +302
Branches 22296 22296
==========================================
+ Hits 497934 498591 +657
+ Misses 69100 68745 -355
Partials 417 417 |
jan-auer
added a commit
that referenced
this pull request
Apr 2, 2025
* master: (96 commits) fix(autofix): fix highlight popup behavior (#88552) 🔧 chore: introduce workflow engine ui links ff (#88569) feat(pipeline): Add CoveragePageWrapper component and tests for it (#88519) feat(taskworker):Make sdk tasks taskworker compatible (#88488) chore(flamegraph): Updating wording to trace (#88516) feat(shared-views): Create `GET` `group-search-view/starred` endpoint (#88398) DI-612: print flaky pytest errors to log (v2) (#88512) chore(nav): Update banner copy (#88566) feat(sentryapps): add RPC method to get all installation component contents (#88179) chore(issue summary): Add limit to query (#88563) fix(dashboards): Add limit suggestion to validation (#88436) feat(checkout): show starting PAYG prices (#88510) ✨ feat(aci): add workflow_id when creating an ephemeral rule in noa (#88520) fix(billing): hide pay now button for self serve partners (#88504) chore(HC): Re-adds logging with a low sample rate for cache hits/misses on options (#88464) fix(logs): Upgrade sentry log integration to fix dogfooding issues (#88561) chore(issue summary): Remove dividers from AI summary alert (#88554) feat(insights): Enable bubbles in full-screen mode (#88445) fix(explore): Update search bar query on filter change (#88473) chore(dependencies): Upgrade drf-spectacular (#88459) ...
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…88561) - Some things you tried to log would fail because they weren't JSON-able - There is now batching logic to reduce CPU load - Various things have been renamed (like before_emit_log -> before_send_log)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.