chore(inc-1100): Bump sentry-redis-tools to retry on timeout error #88559
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😞 |
|
Revert this commit: getsentry/sentry-redis-tools@990fdca seems like we never followed through here |
shruthilayaj
added a commit
to getsentry/sentry-redis-tools
that referenced
this pull request
Apr 2, 2025
getsentry/sentry#88559 requires some fixes in sentry-redis-tools but running into dependency issues trying to bump the package version. ERROR: Cannot install -r requirements-dev-frozen.txt (line 167), -r requirements-dev-frozen.txt (line 169), -r requirements-dev-frozen.txt (line 193) and redis==3.4.1 because these package versions have conflicting dependencies. The conflict is caused by: The user requested redis==3.4.1 rb 1.10.0 depends on redis!=3.4.0 and >=2.6 redis-py-cluster 2.1.0 depends on redis<4.0.0 and >=3.0.0 sentry-redis-tools 0.4.0 depends on redis>=4.0 reverting https://github.com/getsentry/sentry-redis-tools/pull/12/files per @untitaker's suggestion here. I reverted all the changes in that commit since I wasn't sure what is pertinent to the redis>=3.0 -> redis>=4.0 change. Had to manually port the changes, since files had changed for me to be able to open an automatic revert PR.
untitaker
approved these changes
Apr 2, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
…88559) In #inc-1100 we saw backpressure kick in for transaction ingestion in `de` and `us` regions because of TimeoutErrors when connecting to the redis cluster. https://github.com/getsentry/sentry-redis-tools/releases/tag/0.4.0 adds support to retry on TimeoutErrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #inc-1100 we saw backpressure kick in for transaction ingestion in
deandusregions because of TimeoutErrors when connecting to the redis cluster.https://github.com/getsentry/sentry-redis-tools/releases/tag/0.4.0 adds support to retry on TimeoutErrors