fix(dashboards): Improve series alias resolution #88556
Merged
+52
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is different from the label! It's a steady value, used under-the-hood in ECharts.
It's a little ambiguous and doesn't match other formatters
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Fixes DAIN-143. There's a subtle bug (introduced in #87023) in which if multiple plottables had the same alias, ECharts would merge them in the legend. e.g., imagine plotting `span.duration` for two really long queries. The truncation series name formatter would clip the names, and if the first parts of the queries match they'd have the same name, and the same legend entry. Confusing! This PR resolves that problem, and ensures that every plottable has a legend entry. ## Changes - add `Plottable.name`, a string property that's passed directly to ECharts. This is a steady under-the-hood value that ECharts uses when passing stuff around - resolve all aliases ahead-of-time, so they're fast to look up - defer to aliases when rendering tooltips and legends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DAIN-143. There's a subtle bug (introduced in #87023) in which if multiple plottables had the same alias, ECharts would merge them in the legend. e.g., imagine plotting
span.durationfor two really long queries. The truncation series name formatter would clip the names, and if the first parts of the queries match they'd have the same name, and the same legend entry. Confusing! This PR resolves that problem, and ensures that every plottable has a legend entry.Changes
Plottable.name, a string property that's passed directly to ECharts. This is a steady under-the-hood value that ECharts uses when passing stuff around