Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(symbolicator): Prepare tests for symbolicator update #88551

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Apr 2, 2025

Preparation for: getsentry/symbolicator#1667

Until this is merged into Symbolicator we need to check 2 snapshots.

@Dav1dde Dav1dde requested a review from a team April 2, 2025 14:08
@Dav1dde Dav1dde self-assigned this Apr 2, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 2, 2025
@Dav1dde Dav1dde enabled auto-merge (squash) April 2, 2025 14:37
@Dav1dde Dav1dde merged commit a44b360 into master Apr 2, 2025
46 checks passed
@Dav1dde Dav1dde deleted the dav1d/symbolicator-update-prepare branch April 2, 2025 14:38
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tests/symbolicator/test_unreal_full.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #88551      +/-   ##
==========================================
- Coverage   87.75%   87.75%   -0.01%     
==========================================
  Files       10013    10013              
  Lines      567352   567374      +22     
  Branches    22297    22297              
==========================================
+ Hits       497860   497877      +17     
- Misses      69075    69080       +5     
  Partials      417      417              

andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
Preparation for: getsentry/symbolicator#1667

Until this is merged into Symbolicator we need to check 2 snapshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants