Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboards): Unnest <ul> elements from <p> elements in Story #88546

Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix(dashboards): Unnest <ul> elements from <p> elements in Story #88546

merged 1 commit into from
Apr 2, 2025

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Apr 2, 2025

We had some illegal nesting in the Story, which adds distracting errors to the console.

@gggritso gggritso requested a review from a team as a code owner April 2, 2025 13:34
@gggritso gggritso changed the title fix(dashboards): Unnest <ul> elements from <p> elements fix(dashboards): Unnest <ul> elements from <p> elements in Story Apr 2, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 2, 2025
@gggritso gggritso requested a review from a team April 2, 2025 13:35
billyvg
billyvg approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight to jail

@gggritso gggritso enabled auto-merge (squash) April 2, 2025 13:36
@gggritso gggritso merged commit 8423c78 into master Apr 2, 2025
43 checks passed
@gggritso gggritso deleted the fix/dashboards/fix-bad-nesting-in-time-series-story branch April 2, 2025 13:50
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@gggritso @andrewshie-sentry
fix(dashboards): Unnest <ul> elements from <p> elements in Story (#…
4986d44 
…88546)

We had some illegal nesting in the Story, which adds distracting errors
to the console.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gggritso @billyvg