Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: style pagination text and icons in chart legends #88538

Merged
merged 3 commits into from
Apr 3, 2025
Merged

fix: style pagination text and icons in chart legends #88538

merged 3 commits into from
Apr 3, 2025

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Apr 2, 2025

This is a fix for styling pagination of the legend inside charts. It’s NOT related to chonk, as it wasn’t styled at all, which means it wasn’t readable in darkmode in the old theme either.

default theme, before:

Screenshot 2025-04-02 at 13 46 21
Screenshot 2025-04-02 at 13 46 36

default theme, after:

Screenshot 2025-04-02 at 13 47 00
Screenshot 2025-04-02 at 13 47 05

chonk theme, before:

Screenshot 2025-04-02 at 13 49 14
Screenshot 2025-04-02 at 13 49 21

chonk theme, after:

Screenshot 2025-04-02 at 13 49 43
Screenshot 2025-04-02 at 13 49 48

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 2, 2025
@TkDodo TkDodo marked this pull request as ready for review April 2, 2025 11:52
@TkDodo TkDodo requested a review from a team as a code owner April 2, 2025 11:52
@TkDodo TkDodo requested a review from a team April 2, 2025 11:52
gggritso
gggritso approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@TkDodo TkDodo enabled auto-merge (squash) April 3, 2025 08:24
@TkDodo TkDodo merged commit 116398e into master Apr 3, 2025
41 checks passed
@TkDodo TkDodo deleted the tkdodo/fix/legend-pagination-styles branch April 3, 2025 08:39
adrian-codecov pushed a commit that referenced this pull request Apr 3, 2025
@TkDodo @adrian-codecov
fix: style pagination text and icons in chart legends (#88538)
30ee46e 
This is a fix for styling pagination of the legend inside charts. It’s
NOT related to `chonk`, as it wasn’t styled at all, which means it
wasn’t readable in darkmode in the old theme either.

default theme, before:

![Screenshot 2025-04-02 at 13 46
21](https://github.com/user-attachments/assets/ab4e2630-31d5-4350-9f8c-276fe2ac5cf1)
![Screenshot 2025-04-02 at 13 46
36](https://github.com/user-attachments/assets/d21be57d-b458-409c-b041-ff44c20de7b7)

default theme, after:

![Screenshot 2025-04-02 at 13 47
00](https://github.com/user-attachments/assets/b2a8a6f8-bc0c-48f2-a377-f536b83c5fbe)
![Screenshot 2025-04-02 at 13 47
05](https://github.com/user-attachments/assets/83f39ef4-9cbc-4a48-85d6-6a2edc99b5de)

chonk theme, before:

![Screenshot 2025-04-02 at 13 49
14](https://github.com/user-attachments/assets/4b655333-5fbd-4368-a4ba-8eb6e8e5b11d)
![Screenshot 2025-04-02 at 13 49
21](https://github.com/user-attachments/assets/552b7eb2-b3d7-4463-9687-a9fcfe7dba16)

chonk theme, after:

![Screenshot 2025-04-02 at 13 49
43](https://github.com/user-attachments/assets/b48a8891-fe0f-4402-9f29-4adb142d282a)
![Screenshot 2025-04-02 at 13 49
48](https://github.com/user-attachments/assets/864872be-d282-4dbe-bbee-b4c264acdbf8)
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@TkDodo @andrewshie-sentry
fix: style pagination text and icons in chart legends (#88538)
8a194a8 
This is a fix for styling pagination of the legend inside charts. It’s
NOT related to `chonk`, as it wasn’t styled at all, which means it
wasn’t readable in darkmode in the old theme either.

default theme, before:

![Screenshot 2025-04-02 at 13 46
21](https://github.com/user-attachments/assets/ab4e2630-31d5-4350-9f8c-276fe2ac5cf1)
![Screenshot 2025-04-02 at 13 46
36](https://github.com/user-attachments/assets/d21be57d-b458-409c-b041-ff44c20de7b7)

default theme, after:

![Screenshot 2025-04-02 at 13 47
00](https://github.com/user-attachments/assets/b2a8a6f8-bc0c-48f2-a377-f536b83c5fbe)
![Screenshot 2025-04-02 at 13 47
05](https://github.com/user-attachments/assets/83f39ef4-9cbc-4a48-85d6-6a2edc99b5de)

chonk theme, before:

![Screenshot 2025-04-02 at 13 49
14](https://github.com/user-attachments/assets/4b655333-5fbd-4368-a4ba-8eb6e8e5b11d)
![Screenshot 2025-04-02 at 13 49
21](https://github.com/user-attachments/assets/552b7eb2-b3d7-4463-9687-a9fcfe7dba16)

chonk theme, after:

![Screenshot 2025-04-02 at 13 49
43](https://github.com/user-attachments/assets/b48a8891-fe0f-4402-9f29-4adb142d282a)
![Screenshot 2025-04-02 at 13 49
48](https://github.com/user-attachments/assets/864872be-d282-4dbe-bbee-b4c264acdbf8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TkDodo @gggritso