Skip to content

fix(node-profiling): Onboarding instructions #88521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

fix(node-profiling): Onboarding instructions #88521

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
334fdaa
fix(node-profiling): Onboarding instructions
ArthurKnaus Apr 2, 2025
bc9f5e2
fix tests
ArthurKnaus Apr 2, 2025
5b84ada
fix hapi test
ArthurKnaus Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix hapi test
  • Loading branch information
@ArthurKnaus
ArthurKnaus committed Apr 2, 2025
commit 5b84adaf0ffb17f7224880ebb51e88392946c72f
6 changes: 3 additions & 3 deletions static/app/gettingStartedDocs/node/hapi.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ describe('hapi onboarding docs', function () {
expect(
screen.getByText(textWithMarkupMatcher(/tracesSampleRate/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/profileSessionSampleRate: 1.0/))
).toBeInTheDocument();
});

it('enables performance setting the tracesSampleRate to 1', () => {
Expand All @@ -60,9 +63,6 @@ describe('hapi onboarding docs', function () {
expect(
screen.getByText(textWithMarkupMatcher(/tracesSampleRate: 1\.0/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/profileSessionSampleRate: 1.0/))
).toBeInTheDocument();
});

it('enables profiling by setting profiling samplerates', () => {
Expand Down
Loading