ref(tests): Rename disableRouterMocks to enableRouterMocks #88513
+164
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88513 +/- ##
==========================================
+ Coverage 87.74% 87.76% +0.01%
==========================================
Files 10014 10010 -4
Lines 567528 566789 -739
Branches 22298 22283 -15
==========================================
- Hits 498000 497414 -586
+ Misses 69111 68956 -155
- Partials 417 419 +2 |
138100d to
10ee5ce
Compare
10ee5ce to
e2ac6bf
Compare
ryan953
reviewed
Apr 2, 2025
| @@ -137,6 +138,7 @@ function patchBrowserHistoryMocksEnabled(history: MemoryHistory, router: Injecte | |||
| } | |||
|
|
|||
| function makeAllTheProviders(options: ProviderOptions) { | |||
| const enableRouterMocks = options.enableRouterMocks ?? true; | |||
ryan953
approved these changes
Apr 2, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
In preparation for making the new test routing the default behavior, I'm inverting `disableRouterMocks`. This will make the ergonomics slightly better, where toggling on the legacy behavior will be done with `enableRouterMocks: true`, and `enableRouterMocks` will be deprecated. For now this inverts all the existing usages, but does not change the default behavior. The next step will be to add `enableRouterMocks: true` for all other tests and change the default to use the new routing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/getsentry/frontend-tsc/issues/85
In preparation for making the new test routing the default behavior, I'm inverting
disableRouterMocks. This will make the ergonomics slightly better, where toggling on the legacy behavior will be done withenableRouterMocks: true, andenableRouterMockswill be deprecated.For now this inverts all the existing usages, but does not change the default behavior. The next step will be to add
enableRouterMocks: truefor all other tests and change the default to use the new routing.