Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove url from seer rpc signature #88508

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sentry-autofix[bot]
Copy link
Contributor

@sentry-autofix sentry-autofix bot commented Apr 1, 2025

👋 Hi there! This PR was automatically generated by Autofix 🤖

This fix was triggered by Jenn Mueng.

Fixes SEER-SP. The issue was that: Seer's SENTRY_BASE_URL environment variable, configured with a trailing dot, caused signature verification to fail, resulting in a 401 error.

The seer rpc signature should not include the url.

If you have any questions or feedback for the Sentry team about this fix, please email [email protected] with the Run ID: 14267.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
24689 1 24688 294
View the top 1 failed test(s) by shortest run time
tests.sentry.api.endpoints.test_seer_rpc.TestSeerRpc::test_404
Stack Traces | 0.164s run time
#x1B[1m#x1B[.../api/endpoints/test_seer_rpc.py#x1B[0m:38: in test_404
    assert response.status_code == 404
#x1B[1m#x1B[31mE   assert 401 == 404#x1B[0m
#x1B[1m#x1B[31mE    +  where 401 = <Response status_code=401, "application/json">.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants