Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ourlogs): Use item_type in TraceItemDetails hook #88500

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Apr 1, 2025

Summary

The backend supports trace item type instead of 'dataset' now, and should use it moving forward.

The backend supports trace item type instead of 'dataset' now, and should use it moving forward.
@k-fish k-fish self-assigned this Apr 1, 2025
@k-fish k-fish requested a review from a team as a code owner April 1, 2025 21:26
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025
@k-fish k-fish enabled auto-merge (squash) April 1, 2025 21:27
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

@k-fish k-fish merged commit 11ff2f7 into master Apr 1, 2025
41 checks passed
@k-fish k-fish deleted the ref/ourlogs/remove-dataset-and-use-trace-item-type branch April 1, 2025 21:42
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
### Summary
The backend supports trace item type instead of 'dataset' now, and
should use it moving forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants