feat(dashboards): Add onHighlight support to plottables
#88491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just for stories.
This is under-the-hood, but is useful externally in some cases, to figure out what range something is responsible for.
Otherwise, they re-render too often.
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
All plottables can have an `onHighlight` configuration option. If passed, it'll call the callback with the original data point that is responsible for that plotted point. Mapping from series highlights to original data is a little complicated, so I added a bunch of line annotations for how it works. Closes [DAIN-123: Add an `onHighlight` support to `Plottable` objects](https://linear.app/getsentry/issue/DAIN-123/add-an-onhighlight-support-to-plottable-objects) ## Functional Changes `Area` and `Line` plottables now split the dataset into complete and incomplete at instantiation time, not at render time. This makes it possible to then do a reverse lookup, and figure out the split when highlighting. `onHighlight` callback in all plottables accepts an offset index, which they can use the look up the corresponding data. `TimeSeriesWidgetVisualization` correctly calculates a `dataIndex` and an offset and passes it to any `Plottable` that is involved in a `"highlight"` event
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
All plottables can have an `onHighlight` configuration option. If passed, it'll call the callback with the original data point that is responsible for that plotted point. Mapping from series highlights to original data is a little complicated, so I added a bunch of line annotations for how it works. Closes [DAIN-123: Add an `onHighlight` support to `Plottable` objects](https://linear.app/getsentry/issue/DAIN-123/add-an-onhighlight-support-to-plottable-objects) ## Functional Changes `Area` and `Line` plottables now split the dataset into complete and incomplete at instantiation time, not at render time. This makes it possible to then do a reverse lookup, and figure out the split when highlighting. `onHighlight` callback in all plottables accepts an offset index, which they can use the look up the corresponding data. `TimeSeriesWidgetVisualization` correctly calculates a `dataIndex` and an offset and passes it to any `Plottable` that is involved in a `"highlight"` event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All plottables can have an
onHighlightconfiguration option. If passed, it'll call the callback with the original data point that is responsible for that plotted point. Mapping from series highlights to original data is a little complicated, so I added a bunch of line annotations for how it works.Closes DAIN-123: Add an
onHighlightsupport toPlottableobjectsFunctional Changes
AreaandLineplottables now split the dataset into complete and incomplete at instantiation time, not at render time. This makes it possible to then do a reverse lookup, and figure out the split when highlighting.onHighlightcallback in all plottables accepts an offset index, which they can use the look up the corresponding data.TimeSeriesWidgetVisualizationcorrectly calculates adataIndexand an offset and passes it to anyPlottablethat is involved in a"highlight"event