Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema-hints): Add border to schema hints drawer search bar #88486

Merged
merged 1 commit into from
Apr 2, 2025
Merged

fix(schema-hints): Add border to schema hints drawer search bar #88486

merged 1 commit into from
Apr 2, 2025

Conversation

nikkikapadia
Copy link
Member

Addresses this bug and this. It has a border now yay

image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2025
@nikkikapadia nikkikapadia marked this pull request as ready for review April 1, 2025 20:32
@nikkikapadia nikkikapadia requested a review from a team as a code owner April 1, 2025 20:32
@nikkikapadia nikkikapadia merged commit 238d5f1 into master Apr 2, 2025
41 checks passed
@nikkikapadia nikkikapadia deleted the nikki/fix/highlight-schema-hints-drawer-search branch April 2, 2025 13:28
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@nikkikapadia @andrewshie-sentry
fix(schema-hints): Add border to schema hints drawer search bar (#88486)
4e0641a 
Addresses [this
bug](https://www.notion.so/sentry/Search-bar-in-Filter-Attributes-drawer-should-be-highlighted-as-default-1c08b10e4b5d801a93b7d5b7e76dbfef?pvs=4)
and
[this](https://www.notion.so/sentry/Filter-Attributes-in-one-line-1c08b10e4b5d8045b435fbe369b5b430?pvs=4).
It has a border now yay


![image](https://github.com/user-attachments/assets/47473da5-7ec1-4833-bfb7-198284458437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abdkhan14 Abdkhan14 Abdkhan14 approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikkikapadia @Abdkhan14