Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans-metrics): has filter not working with column_remapping alias #88483

Merged

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Apr 1, 2025

I noticed after this PR #88447
The has filter doesn't work for column_remapping in spans metrics. This PR fixes that issue

@DominikB2014 DominikB2014 requested a review from a team as a code owner April 1, 2025 20:07
@DominikB2014 DominikB2014 changed the title fix(spans-metrics): has filter not working with field alias fix(spans-metrics): has filter not working with column_remapping alias Apr 1, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 1, 2025
Copy link

sentry-io bot commented Apr 1, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/search/events/builder/metrics.py

Function Unhandled Issue
resolve_tag_key IncompatibleMetricsQuery: url is not a tag in the metrics dataset sentry.snuba.tasks.delete_subscr...
Event Count: 992
resolve_tag_key IncompatibleMetricsQuery: transaction.duration is not a tag in the metrics dataset sentry.snuba.ta...
Event Count: 992

Did you find this useful? React with a 👍 or 👎

@DominikB2014 DominikB2014 merged commit 46a53e3 into master Apr 1, 2025
51 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/fix-has-filter-span-metrics-alias branch April 1, 2025 20:57
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
…ias (#88483)

I noticed after this PR #88447
The `has` filter doesn't work for `column_remapping` in spans metrics.
This PR fixes that issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants